Add a bit of lag to the JWT renewal time.#3592
Merged
mitchell-as merged 2 commits intoversion/0-48-0-RC1from Nov 14, 2024
Merged
Add a bit of lag to the JWT renewal time.#3592mitchell-as merged 2 commits intoversion/0-48-0-RC1from
mitchell-as merged 2 commits intoversion/0-48-0-RC1from
Conversation
It was possible to land within the interval between actual expired time and expected expired time.
Naatan
suggested changes
Nov 14, 2024
Contributor
Naatan
left a comment
Naatan
left a comment
There was a problem hiding this comment.
This is effectively duplicating the logic here:
cli/pkg/platform/authentication/auth.go
Line 151 in 8e47470
Suggest instead lowering the lifetime to say 50 minutes:
cli/pkg/platform/authentication/auth.go
Line 41 in 8e47470
Naatan
approved these changes
Nov 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was possible to land within the interval between actual expired time and expected expired time.
I did my best to try and reproduce this, but I wasn't able to. I genuinely think I landed in the brief window of time where the JWT expired on the Platform, but state-svc or state tool thought it was still valid. Reducing the time state-svc or state tool think it's valid should avoid this. Either way, it's not something our users will run into on a regular basis (and waiting a minute or two for the state-svc poller to refresh would have silently fixed this error).